tito97sp commented on a change in pull request #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#discussion_r757917217
##########
File path: boards/arm/stm32h7/nucleo-h743zi/configs/mcuboot-app/defconfig
##########
@@ -0,0 +1,142 @@
+#
+# This file is autogenerated: PLEASE DO NOT EDIT IT.
+#
+# You can use "make menuconfig" to make any modifications to the installed
.config file.
+# You can then do "make savedefconfig" to generate a new defconfig file that
includes your
+# modifications.
+#
+# CONFIG_SPI_EXCHANGE is not set
+# CONFIG_STM32H7_SYSCFG is not set
+CONFIG_APP_FORMAT_MCUBOOT=y
+CONFIG_APP_MCUBOOT_BOOTLOADER=y
Review comment:
I have some doubts respect this CONFIG flag. When selected it indicates
the linker to use the `xxx-mcuboot-loader.ld` linker script in place of
`xxx-mcuboot-app.ld`. This is confusing because of the word **APP** in the
"CONFIG_APP_MCUBOOT_BOOTLOADER" flag.
Has you think in using the inverse logic??
CONFIG_APP_MCUBOOT_BOOTLOADER=y --> use xxx-mcuboot-app.ld
CONFIG_APP_MCUBOOT_BOOTLOADER=y --> use xxx-mcuboot-laoder.ld
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
