pkarashchenko commented on a change in pull request #4908: URL: https://github.com/apache/incubator-nuttx/pull/4908#discussion_r758190672
########## File path: boards/arm/stm32h7/nucleo-h743zi/Kconfig ########## @@ -27,4 +27,66 @@ config STM32_ROMFS_IMAGEFILE depends on STM32_ROMFS default "../../../rom.img" + +config PROGMEM_OTA_PARTITION + bool "Progmem ota partitions" + default n + select MTD + select MTD_BYTE_WRITE + select MTD_PARTITION + select MTD_PROGMEM + select MTD_PROGMEM_ERASESTATE + +menuconfig STM32_FORMAT_MCUBOOT + bool "MCUboot-bootable format" + default n + select PROGMEM_OTA_PARTITION + ---help--- + The MCUboot support of loading the firmware images. + +if STM32_FORMAT_MCUBOOT + +config STM32_MCUBOOT_BOOTLOADER + bool "MCUboot bootloader application" + default n + ---help--- + This switch between linker scripts to allow an application be + built to another entry point address. + +comment "MCUboot Application Image OTA Update support" + +config OTA_PRIMARY_SLOT_DEVPATH + string "Application image primary slot device path" + default "/dev/ota0" + +config OTA_SECONDARY_SLOT_DEVPATH + string "Application image secondary slot device path" + default "/dev/ota1" + +config OTA_SCRATCH_DEVPATH + string "Scratch partition device path" + default "/dev/otascratch" + +config OTA_PRIMARY_SLOT_OFFSET + hex "MCUboot application image primary slot offset" + default "0x20000" + +config OTA_SECONDARY_SLOT_OFFSET + hex "MCUboot application image secondary slot offset" + default "0x100000" + +config OTA_SCRATCH_OFFSET + hex "MCUboot scratch partition offset" + default "0x1c0000" + +config OTA_SLOT_SIZE Review comment: ```suggestion config STM32_OTA_SLOT_SIZE ``` ########## File path: boards/arm/stm32h7/nucleo-h743zi/Kconfig ########## @@ -27,4 +27,66 @@ config STM32_ROMFS_IMAGEFILE depends on STM32_ROMFS default "../../../rom.img" + +config PROGMEM_OTA_PARTITION + bool "Progmem ota partitions" + default n + select MTD + select MTD_BYTE_WRITE + select MTD_PARTITION + select MTD_PROGMEM + select MTD_PROGMEM_ERASESTATE + +menuconfig STM32_FORMAT_MCUBOOT + bool "MCUboot-bootable format" + default n + select PROGMEM_OTA_PARTITION + ---help--- + The MCUboot support of loading the firmware images. + +if STM32_FORMAT_MCUBOOT + +config STM32_MCUBOOT_BOOTLOADER + bool "MCUboot bootloader application" + default n + ---help--- + This switch between linker scripts to allow an application be + built to another entry point address. + +comment "MCUboot Application Image OTA Update support" + +config OTA_PRIMARY_SLOT_DEVPATH + string "Application image primary slot device path" + default "/dev/ota0" + +config OTA_SECONDARY_SLOT_DEVPATH + string "Application image secondary slot device path" + default "/dev/ota1" + +config OTA_SCRATCH_DEVPATH + string "Scratch partition device path" + default "/dev/otascratch" + +config OTA_PRIMARY_SLOT_OFFSET + hex "MCUboot application image primary slot offset" + default "0x20000" + +config OTA_SECONDARY_SLOT_OFFSET + hex "MCUboot application image secondary slot offset" + default "0x100000" + +config OTA_SCRATCH_OFFSET Review comment: ```suggestion config STM32_OTA_SCRATCH_OFFSET ``` ########## File path: boards/arm/stm32h7/nucleo-h743zi/Kconfig ########## @@ -27,4 +27,66 @@ config STM32_ROMFS_IMAGEFILE depends on STM32_ROMFS default "../../../rom.img" + +config PROGMEM_OTA_PARTITION + bool "Progmem ota partitions" + default n + select MTD + select MTD_BYTE_WRITE + select MTD_PARTITION + select MTD_PROGMEM + select MTD_PROGMEM_ERASESTATE + +menuconfig STM32_FORMAT_MCUBOOT + bool "MCUboot-bootable format" + default n + select PROGMEM_OTA_PARTITION + ---help--- + The MCUboot support of loading the firmware images. + +if STM32_FORMAT_MCUBOOT + +config STM32_MCUBOOT_BOOTLOADER + bool "MCUboot bootloader application" + default n + ---help--- + This switch between linker scripts to allow an application be + built to another entry point address. + +comment "MCUboot Application Image OTA Update support" + +config OTA_PRIMARY_SLOT_DEVPATH + string "Application image primary slot device path" + default "/dev/ota0" + +config OTA_SECONDARY_SLOT_DEVPATH + string "Application image secondary slot device path" + default "/dev/ota1" + +config OTA_SCRATCH_DEVPATH + string "Scratch partition device path" + default "/dev/otascratch" + +config OTA_PRIMARY_SLOT_OFFSET + hex "MCUboot application image primary slot offset" + default "0x20000" + +config OTA_SECONDARY_SLOT_OFFSET + hex "MCUboot application image secondary slot offset" + default "0x100000" + +config OTA_SCRATCH_OFFSET + hex "MCUboot scratch partition offset" + default "0x1c0000" + +config OTA_SLOT_SIZE + hex "MCUboot application image slot size (in bytes)" + default "0xc0000" + +config OTA_SCRATCH_SIZE Review comment: ```suggestion config STM32_OTA_SCRATCH_SIZE ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org