tito97sp commented on a change in pull request #4908:
URL: https://github.com/apache/incubator-nuttx/pull/4908#discussion_r766762630



##########
File path: boards/arm/stm32h7/nucleo-h743zi/Kconfig
##########
@@ -27,4 +27,66 @@ config STM32_ROMFS_IMAGEFILE
         depends on STM32_ROMFS
         default "../../../rom.img"
 
+
+config PROGMEM_OTA_PARTITION
+       bool "Progmem ota partitions"
+       default n
+       select MTD
+       select MTD_BYTE_WRITE
+       select MTD_PARTITION
+       select MTD_PROGMEM
+       select MTD_PROGMEM_ERASESTATE
+
+menuconfig STM32_FORMAT_MCUBOOT
+       bool "MCUboot-bootable format"
+       default n
+       select PROGMEM_OTA_PARTITION

Review comment:
       Done

##########
File path: boards/arm/stm32h7/nucleo-h743zi/src/stm32_bringup.c
##########
@@ -309,7 +309,7 @@ int stm32_bringup(void)
   ret = cdcacm_initialize(0, NULL);
   if (ret < 0)
     {
-      syslog(LOG_ERR, "ERROR: cdcacm_initialize failed: %d\n", ret);
+        syslog(LOG_ERR, "ERROR: cdcacm_initialize failed: %d\n", ret);

Review comment:
       ok

##########
File path: boards/arm/stm32h7/nucleo-h743zi/src/stm32_bringup.c
##########
@@ -323,5 +323,16 @@ int stm32_bringup(void)
     }
 #endif
 
+#ifdef CONFIG_MTD
+#ifdef HAVE_PROGMEM_CHARDEV
+  ret = stm32_progmem_init();
+  if (ret < 0)
+    {
+      syslog(LOG_ERR, "ERROR: Failed to initialize MTD progmem: %d\n",
+              ret);

Review comment:
       ok.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to