zhaoxiu-zeng commented on a change in pull request #4989:
URL: https://github.com/apache/incubator-nuttx/pull/4989#discussion_r769473926
##########
File path: sched/sched/sched_addreadytorun.c
##########
@@ -158,6 +169,17 @@ bool nxsched_add_readytorun(FAR struct tcb_s *btcb)
int cpu;
int me;
+#if CONFIG_RR_INTERVAL > 0
+#ifdef CONFIG_SCHED_SPORADIC
+ if ((btcb->flags & TCB_FLAG_POLICY_MASK) == TCB_FLAG_SCHED_RR)
+#endif
+ {
+ /* Reset the task's timeslice. */
+
+ btcb->timeslice = MSEC2TICK(CONFIG_RR_INTERVAL);
Review comment:
For the first point, after applying this commit, the behavior is
consistent with linux kernel.
For the second one, the scheduler works too if doesn't reset the task‘s
timeslice, of course.
But I think it would be better to reset the task's timeslice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
