xiaoxiang781216 commented on a change in pull request #4989:
URL: https://github.com/apache/incubator-nuttx/pull/4989#discussion_r769614974
##########
File path: sched/sched/sched_addreadytorun.c
##########
@@ -158,6 +169,17 @@ bool nxsched_add_readytorun(FAR struct tcb_s *btcb)
int cpu;
int me;
+#if CONFIG_RR_INTERVAL > 0
+#ifdef CONFIG_SCHED_SPORADIC
+ if ((btcb->flags & TCB_FLAG_POLICY_MASK) == TCB_FLAG_SCHED_RR)
+#endif
+ {
+ /* Reset the task's timeslice. */
+
+ btcb->timeslice = MSEC2TICK(CONFIG_RR_INTERVAL);
Review comment:
Yes, but the standard compliance is the highest priority of NuttX.
https://github.com/apache/incubator-nuttx/blob/master/INVIOLABLES.md:
```
Strict POSIX compliance
Strict conformance to the portable standard OS interface as defined at
OpenGroup.org.
A deeply embedded system requires some special support. Special support must
be minimized.
The portable interface must never be compromised only for the sake of
expediency.
Expediency or even improved performance are not justifications for violation
of the strict POSIX interface.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
