a-lunev commented on pull request #5012: URL: https://github.com/apache/incubator-nuttx/pull/5012#issuecomment-997404796
> > as we are going to remove at least GPIO_SPEED_50MHz, GPIO_PUSHPULL, GPIO_PULLUP > > I would only remove GPIO_SPEED_xxMHz, not GPIO_PUSHPULL nor GPIO_PULLUP if the setting make make sense for the pin. Most are correct. GPIO_PUSHPULL / GPIO_OPENDRAIN possibly should be retained (right now I can not figure out where it could vary along different boards for a particular type of interface). GPIO_PULLUP depends on PCB circuit design. One of the examples is SDIO. Some boards have external pull-up resistors, some do not. If a board does not have external pull-up resistors, SDIO host of the board should enable its internal pull-up resistors. Otherwise, SDIO host should disable its internal pull-up resistors. Thus at least GPIO_SPEED and GPIO_PULLUP should be definitely removed from pinmap files. > The port encoding is one more place for an error to happen in is not FNF. It is not generically usable: What are you going to do on processors have pad names like GPIO_AD_B1_15 call it GPIO_SDMMC2_CMD_GPIO_AD_B0_10. I would shorten it to GPIO_SDMMC2_CMD_AD_B0_10. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
