davids5 commented on pull request #5012: URL: https://github.com/apache/incubator-nuttx/pull/5012#issuecomment-998030903
> > > I would shorten it to GPIO_SDMMC2_CMD_AD_B0_10. > > > > > > No - please no! > > The key point that keeps getting missed here is: Once there are no ROOT names in the pin map files. > > As I can see there are not root names in some pin map files for some interfaces. What is the issue with that? None - if there are no root names in the pinmap file than the board file **has** to map it and can use any of the 3 methods discussed above. 1. Fully re define it. ``` #define GPIO_SDMMC2_CMD (GPIO_ALT|GPIO_AF9|GPIO_SPEED_50MHz|GPIO_PUSHPULL|GPIO_PORTA|GPIO_PIN0) ``` 2. Use the NON root name (xxxx_n) and ADD to it. ``` #define GPIO_SDMMC2_CMD (GPIO_SDMMC2_CMD_2|GPIO_SPEED_50MHz|GPIO_PUSHPULL) ``` 3. Use the NON root name (xxxx_n) and change it ``` #define ADJ_SLEW_RATE(p) (((p) & ~GPIO_SPEED_MASK) | (GPIO_SPEED_2MHz)) #define GPIO_SPI3_SCK ADJ_SLEW_RATE(GPIO_SPI3_SCK_2) /* PC10 */ ``` > > > The perfectly reasonable default of a GPIO_PULLUP on a UART RX can be removed in the board file. If you need to. That is enough. That is all we need. > > Do you mean to retain some of the reasonable default GPIO_PULLUPs in pin map files and remove the others (from pin map files)? Yes. I think most the PU and Driver type are reasonable. But we should do an audit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
