pkarashchenko commented on a change in pull request #5014:
URL: https://github.com/apache/incubator-nuttx/pull/5014#discussion_r771996880
##########
File path: include/sys/syscall_lookup.h
##########
@@ -218,6 +218,11 @@ SYSCALL_LOOKUP(pwrite, 4)
#ifdef CONFIG_EVENT_FD
SYSCALL_LOOKUP(eventfd, 2)
#endif
+#ifdef CONFIG_TIMER_FD
+ SYSCALL_LOOKUP(timerfd_create, 2)
+ SYSCALL_LOOKUP(timerfd_settime, 4)
+ SYSCALL_LOOKUP(timerfd_gettime, 2)
Review comment:
Can this be done in 2 steps? I really do not mind to go this way, but
since such change goes in another path compared to Linux and require additional
retesting and significant rework (at least IMO) I would like to open an
enhancement issue and involve some more people into discussion instead of doing
changes in this PR. @xiaoxiang781216 does this sounds reasonable?
BTW going with
```
struct timerfd_settime_s {
int flags;
struct itimerspec new_value;
struct itimerspec old_value;
};
```
is not the best as `old_value` is optional parameter that can be `NULL`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
