xiaoxiang781216 commented on a change in pull request #5014:
URL: https://github.com/apache/incubator-nuttx/pull/5014#discussion_r772074608
##########
File path: include/sys/syscall_lookup.h
##########
@@ -218,6 +218,11 @@ SYSCALL_LOOKUP(pwrite, 4)
#ifdef CONFIG_EVENT_FD
SYSCALL_LOOKUP(eventfd, 2)
#endif
+#ifdef CONFIG_TIMER_FD
+ SYSCALL_LOOKUP(timerfd_create, 2)
+ SYSCALL_LOOKUP(timerfd_settime, 4)
+ SYSCALL_LOOKUP(timerfd_gettime, 2)
Review comment:
Sure, let's do in the next step.
> BTW going with
>
> ```
> struct timerfd_settime_s {
> int flags;
> struct itimerspec new_value;
> struct itimerspec old_value;
> };
> ```
>
> is not the best as `old_value` is optional parameter that can be `NULL`.
timerfd_ioctl could return old_value always, but timerfd_settime can skip
the assignment in case of old_value is NULL. This is common trick to move the
dirty work to the userspace library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
