pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780524344
##########
File path: arch/risc-v/include/common/irq.h
##########
@@ -134,6 +140,14 @@
# error not supported !!!
#endif
+/* REG size */
+
+#ifdef CONFIG_ARCH_RV32
+#define REG_SIZE 1
+#else
+#define REG_SIZE 2
+#endif
Review comment:
Where this is used? Probably the idea was to define this before `#ifdef
CONFIG_ARCH_FPU` and have a next code:
```
#if defined(CONFIG_ARCH_DPFPU)
# define FPU_REG_SIZE (2 / REG_SIZE)
#elif defined(CONFIG_ARCH_QPFPU)
# define FPU_REG_SIZE (4 / REG_SIZE)
#else
# if REG_SIZE > 1
# error not supported !!!
# else
# define FPU_REG_SIZE 1
# endif
#endif
```
??
or
```
#if defined(CONFIG_ARCH_DPFPU)
# define FPU_REG_SIZE (2 / REG_SIZE)
#elif defined(CONFIG_ARCH_QPFPU)
# define FPU_REG_SIZE (4 / REG_SIZE)
#else
# define FPU_REG_SIZE (1 / REG_SIZE)
#endif
#if FPU_REG_SIZE == 0
# error not supported !!!
#endif
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
