pkarashchenko commented on a change in pull request #5192:
URL: https://github.com/apache/incubator-nuttx/pull/5192#discussion_r780531230
##########
File path: arch/risc-v/src/qemu-rv32/qemu_rv32_head.S
##########
@@ -154,21 +139,6 @@ exception_common:
lw s0, 32*4(sp) /* restore mstatus */
csrw mstatus, s0
-#if defined(INT_XCPT_REGS) && INT_XCPT_REGS >= 39
- lw x28, 36*4(sp)
- lw x29, 37*4(sp)
- lw x30, 38*4(sp)
- csrrw x0, 0x7b4, x28
- csrrw x0, 0x7b5, x29
- csrrw x0, 0x7b6, x30
- lw x28, 33*4(sp)
- lw x29, 34*4(sp)
- lw x30, 35*4(sp)
- csrrw x0, 0x7b0, x28
- csrrw x0, 0x7b1, x29
- csrrw x0, 0x7b2, x30
-#endif
Review comment:
Why this is removed?
##########
File path: arch/risc-v/src/qemu-rv32/qemu_rv32_head.S
##########
@@ -105,21 +105,6 @@ exception_common:
sw x30, 30*4(sp) /* t5 */
sw x31, 31*4(sp) /* t6 */
-#if defined(INT_XCPT_REGS) && INT_XCPT_REGS >= 39
- csrr x28, 0x7b0
- csrr x29, 0x7b1
- csrr x30, 0x7b2
- sw x28, 33*4(sp)
- sw x29, 34*4(sp)
- sw x30, 35*4(sp)
- csrr x28, 0x7b4
- csrr x29, 0x7b5
- csrr x30, 0x7b6
- sw x28, 36*4(sp)
- sw x29, 37*4(sp)
- sw x30, 38*4(sp)
-#endif
-
Review comment:
Why this is removed?
##########
File path: arch/risc-v/src/rv32m1/rv32m1_irq_dispatch.c
##########
@@ -53,11 +53,11 @@ volatile uint32_t * g_current_regs;
****************************************************************************/
LOCATE_ITCM
-void *rv32m1_dispatch_irq(uint32_t vector, uint32_t *regs)
+void *rv32m1_dispatch_irq(uintptr_t vector, uintptr_t *regs)
{
int vec = vector & 0x1f;
int irq = (vector >> 27) + vec;
Review comment:
```suggestion
uintptr_t vec = vector & 0x1f;
uintptr_t irq = (vector >> 27) + vec;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
