gustavonihei commented on pull request #5254: URL: https://github.com/apache/incubator-nuttx/pull/5254#issuecomment-1014968493
> > FAR qualifier is only required for common code. Many (if not all, haven’t looked at all files) are restricted to chip implementation. Besides, FAR and CODE have already been removed previously from Xtensa and RISC-V. Adding them back would be a step back. > > @gustavonihei I haven't added neither `FAR` nor `CODE` to Xtensa and RISC-V. For each file that I added I examined if `FAR` is already used in that file or not and if I found `FAR` then I added it as well. > > I think that `FAR` and `CODE` keywords removal should be by code for each architecture step by step in all arch dependent places. I just try to keep consistency with existing code. Sorry, @pkarashchenko. I had a quick look on the cellphone and misunderstood some bits of the PR. I'll drop the review for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
