pkarashchenko commented on a change in pull request #5254:
URL: https://github.com/apache/incubator-nuttx/pull/5254#discussion_r786483815



##########
File path: arch/mips/src/pic32mz/pic32mz_ethernet.c
##########
@@ -254,7 +254,7 @@
  * header
  */
 
-#define BUF ((struct eth_hdr_s *)priv->pd_dev.d_buf)
+#define BUF ((FAR struct eth_hdr_s *)priv->pd_dev.d_buf)

Review comment:
       Currently `FAR` is heavily used in arch/mips files. I propose to clean 
it up with a separate task

##########
File path: arch/mips/src/pic32mx/pic32mx_ethernet.c
##########
@@ -215,7 +215,7 @@
  * header
  */
 
-#define BUF ((struct eth_hdr_s *)priv->pd_dev.d_buf)
+#define BUF ((FAR struct eth_hdr_s *)priv->pd_dev.d_buf)

Review comment:
       Currently `FAR` is heavily used in arch/mips files. I propose to clean 
it up with a separate task




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to