xiaoxiang781216 commented on a change in pull request #5273:
URL: https://github.com/apache/incubator-nuttx/pull/5273#discussion_r788463435
##########
File path: arch/risc-v/include/arch.h
##########
@@ -62,6 +62,12 @@ uint32_t up_gethartid(void);
#endif
+/* Provide the maximum amount of page table levels per MMU type */
+
+#ifdef CONFIG_ARCH_MMU_TYPE_SV39
+#define ARCH_PGT_MAX_LEVELS (3)
Review comment:
It normally doesn't need to expose so detailed info outside arch, how
about we move the macro to mmu.h until you really need it?
##########
File path: arch/risc-v/include/arch.h
##########
@@ -62,6 +62,12 @@ uint32_t up_gethartid(void);
#endif
+/* Provide the maximum amount of page table levels per MMU type */
+
+#ifdef CONFIG_ARCH_MMU_TYPE_SV39
+#define ARCH_PGT_MAX_LEVELS (3)
Review comment:
It normally doesn't need to expose so detailed info outside arch, how
about we move the macro to riscv_mmu.h until you really need it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
