xiaoxiang781216 commented on a change in pull request #5296:
URL: https://github.com/apache/incubator-nuttx/pull/5296#discussion_r789395677
##########
File path: net/tcp/tcp_recvfrom.c
##########
@@ -191,10 +191,10 @@ static inline uint16_t tcp_newdata(FAR struct
net_driver_s *dev,
if (nsaved < buflen)
{
nwarn("WARNING: packet data not fully saved "
- "(%d/%u/%zu/%u bytes)\n",
+ "(%d/%u/%u/%u bytes)\n",
buflen - nsaved,
(unsigned int)nsaved,
- recvlen,
+ (unsigned int)recvlen,
Review comment:
can we relax the %z flag? the library feature is different from
language(compiler) feature. libc is provided by NuttX self, and we actually
support many c99 feature. So, c89 in NuttX should be the core/compiler feature,
not the library feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
