a-lunev commented on a change in pull request #5296:
URL: https://github.com/apache/incubator-nuttx/pull/5296#discussion_r789636114
##########
File path: net/tcp/tcp_sendfile.c
##########
@@ -274,6 +276,8 @@ static uint16_t sendfile_eventhandler(FAR struct
net_driver_s *dev,
else if ((flags & TCP_REXMIT) != 0)
{
+ uint32_t sndlen;
Review comment:
> Yes, that's why I suggest that we only need to conform c89 core
language spec, not the whole c89 spec. We have to stick to c89 just because
some arch compiler can't support the c99 grammar. From the language
perspective, c99 is much better than c89, so we should leverage the new 99
feature which not relate to the grammar(such as the platform independent type)
as much as possible.
I agree. So what is the issue with the highlighted line (uint32_t sndlen)?
What is your suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
