jerpelea commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791838798
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
the NN libraries should be accessible by other applications so in my
opinion they should be in NuttX not Apps
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
I was planning to group all NN libraries in this folder
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
In this specific case it will be a DNN runtime library that resides in
apps folder. My plan was to add several NN libraries that can increase the NN
usage with NuttX and help community.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
since those libs should be system wide available in both flat and kernel
builds I would suggest nuttx/nn
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
I will close the PR. test the move to apps and open a new PR. Thanks for
reviewing the change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
