xiaoxiang781216 commented on a change in pull request #5338:
URL: https://github.com/apache/incubator-nuttx/pull/5338#discussion_r791817942
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
is it a pure userspace library? if that, the better place may be apps/nn/
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
What's means 'other application'? I suppose that the key decision where
is better for the 3rd party library is who will use it.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
What's means 'other application'? I suppose that the key decision where
is better place for the 3rd party library is who will use it.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from
different open source project. The key point is which one(apps/nn and nuttx/nn)
is better place.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from
different open source project. The key point is which one(apps/nn or nuttx/nn)
is better place.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
Yes, I agree that we need a folder to hold NN implementation come from
different open source project. The key point is which one(apps/nn or nuttx/nn)
is better place. Here is my thought:
1. If the library will be used by kernel driver, we need to put into nuttx/nn
2. If the library is only used by user space program, apps/nn is more
suitable
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
kernel/flat isn't a key point here. All libraries inside apps folder can
be enabled and link in kernel mode too.
##########
File path: nn/Kconfig
##########
@@ -0,0 +1,16 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+config NN
Review comment:
kernel/flat isn't a key point here. All libraries inside apps folder can
be enabled and link when kernel build is enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
