xiaoxiang781216 commented on a change in pull request #5434:
URL: https://github.com/apache/incubator-nuttx/pull/5434#discussion_r801281895
##########
File path: net/ieee802154/ieee802154_sockif.c
##########
@@ -356,6 +356,7 @@ static int ieee802154_bind(FAR struct socket *psock,
FAR const struct sockaddr *addr,
socklen_t addrlen)
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
reuse conn at line 362
##########
File path: net/socket/setsockopt.c
##########
@@ -75,6 +75,8 @@ static int psock_socketlevel_option(FAR struct socket *psock,
int option,
FAR const void *value,
socklen_t value_len)
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: net/socket/net_sendfile.c
##########
@@ -104,6 +104,7 @@
ssize_t psock_sendfile(FAR struct socket *psock, FAR struct file *infile,
FAR off_t *offset, size_t count)
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: fs/procfs/fs_procfsproc.c
##########
@@ -1177,11 +1177,11 @@ static ssize_t proc_groupfd(FAR struct proc_file_s
*procfile,
if (file->f_inode && INODE_IS_SOCKET(file->f_inode))
{
FAR struct socket *socket = file->f_priv;
+ FAR struct socket_conn_s *sconn = socket->s_conn;
Review comment:
sconn->conn
##########
File path: net/inet/ipv6_getpeername.c
##########
@@ -69,6 +69,7 @@
int ipv6_getpeername(FAR struct socket *psock, FAR struct sockaddr *addr,
FAR socklen_t *addrlen)
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: net/inet/ipv4_getpeername.c
##########
@@ -71,6 +71,7 @@ int ipv4_getpeername(FAR struct socket *psock, FAR struct
sockaddr *addr,
{
#if defined(NET_TCP_HAVE_STACK) || defined(NET_UDP_HAVE_STACK)
FAR struct sockaddr_in *outaddr = (FAR struct sockaddr_in *)addr;
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: net/inet/inet_sockif.c
##########
@@ -1069,6 +1071,9 @@ static int inet_poll(FAR struct socket *psock, FAR struct
pollfd *fds,
static ssize_t inet_send(FAR struct socket *psock, FAR const void *buf,
size_t len, int flags)
{
+#ifdef NET_UDP_HAVE_STACK
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: net/inet/inet_sockif.c
##########
@@ -716,9 +716,11 @@ static int inet_connect(FAR struct socket *psock,
#if defined(CONFIG_NET_TCP) && defined(NET_TCP_HAVE_STACK)
case SOCK_STREAM:
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: net/netlink/netlink_sockif.c
##########
@@ -756,6 +756,7 @@ static ssize_t netlink_sendmsg(FAR struct socket *psock,
static ssize_t netlink_recvmsg(FAR struct socket *psock,
FAR struct msghdr *msg, int flags)
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
##########
File path: net/local/local_sockif.c
##########
@@ -515,9 +515,11 @@ static int local_connect(FAR struct socket *psock,
#ifdef CONFIG_NET_LOCAL_STREAM
case SOCK_STREAM:
{
+ FAR struct socket_conn_s *sconn = psock->s_conn;
Review comment:
sconn->conn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
