pkarashchenko commented on a change in pull request #5696:
URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r821754389
##########
File path: libs/libc/symtab/symtab_allsyms.c
##########
@@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value,
symbol = symtab_findbyvalue(g_allsyms, value, g_nallsyms);
}
- if (symbol && symbol != &g_allsyms[g_nallsyms - 1])
+ if (size)
Review comment:
```suggestion
if (size > 0)
```
##########
File path: libs/libc/symtab/symtab_allsyms.c
##########
@@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value,
symbol = symtab_findbyvalue(g_allsyms, value, g_nallsyms);
}
- if (symbol && symbol != &g_allsyms[g_nallsyms - 1])
+ if (size)
{
- *size = (symbol + 1)->sym_value - symbol->sym_value;
- }
- else
- {
- *size = 0;
+ if (symbol && symbol != &g_allsyms[g_nallsyms - 1])
Review comment:
```suggestion
if (symbol != NULL && symbol != &g_allsyms[g_nallsyms - 1])
```
##########
File path: libs/libc/stdio/lib_libvsprintf.c
##########
@@ -488,6 +488,61 @@ static int vsprintf_internal(FAR struct lib_outstream_s
*stream,
if (c == 'p')
{
+ unsigned char sub_c = fmt_char(fmt);
+
+ switch (sub_c)
+ {
+ case 'V':
+ {
+ FAR struct va_format *vaf = va_arg(ap, void *);
Review comment:
```suggestion
FAR struct va_format *vaf = va_arg(ap, FAR struct
va_format *);
```
But I'm not sure if that is possible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
