xiaoxiang781216 commented on a change in pull request #5696:
URL: https://github.com/apache/incubator-nuttx/pull/5696#discussion_r822259851
##########
File path: arch/sim/src/sim/up_head.c
##########
@@ -52,6 +53,46 @@ char **g_argv;
static char g_logbuffer[4096];
#endif
+#ifdef CONFIG_ALLSYMS
+extern struct symtab_s g_allsyms[1];
Review comment:
change to:
```
extern struct symtab_s g_allsyms[];
```
##########
File path: tools/mkallsyms.sh
##########
@@ -21,7 +21,7 @@
export LC_ALL=C
-usage="Usage: $0 <ELFBIN> <CROSSDEV>"
+usage="Usage: $0 <noconst> <ELFBIN> <CROSSDEV>"
Review comment:
<noconst> to [noconst]
##########
File path: libs/libc/symtab/symtab_allsyms.c
##########
@@ -58,13 +58,16 @@ allsyms_lookup(FAR const char *name, FAR void *value,
symbol = symtab_findbyvalue(g_allsyms, value, g_nallsyms);
}
- if (symbol && symbol != &g_allsyms[g_nallsyms - 1])
+ if (size)
Review comment:
don't need change this file now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
