pkarashchenko commented on a change in pull request #5703:
URL: https://github.com/apache/incubator-nuttx/pull/5703#discussion_r822520975
##########
File path: libs/libc/machine/arm/gnu/arch_setjmp.S
##########
@@ -64,7 +59,10 @@
*
****************************************************************************/
+#ifdef CONFIG_ARM_THUMB
+ .thumb
Review comment:
Do we really need `.thumb` here?
##########
File path: arch/Kconfig
##########
@@ -15,6 +15,7 @@ config ARCH_ARM
select ARCH_HAVE_STACKCHECK
select ARCH_HAVE_CUSTOMOPT
select ARCH_HAVE_STDARG_H
+ select ARCH_HAVE_SETJMP if !ARCH_TOOLCHAIN_IAR
Review comment:
So both GCC and Clang need it yes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
