davids5 commented on a change in pull request #1066:
URL:
https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r828029803
##########
File path: netutils/ping/icmpv6_ping.c
##########
@@ -57,12 +59,22 @@
* separate instance of g_ping6_id in every process space.
*/
-static uint16_t g_ping6_id = 0;
+static uint16_t g_ping6_id;
+static volatile bool exiting;
Review comment:
```suggestion
static volatile bool g_exiting;
```
##########
File path: netutils/ping/icmp_ping.c
##########
@@ -58,12 +60,22 @@
* separate instance of g_pingid in every process space.
*/
-static uint16_t g_pingid = 0;
+static uint16_t g_pingid;
+static volatile bool exiting;
Review comment:
g_ prefix need;
```suggestion
static volatile bool g_exiting;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
