xiaoxiang781216 commented on a change in pull request #1066: URL: https://github.com/apache/incubator-nuttx-apps/pull/1066#discussion_r828738400
########## File path: system/ping/ping.c ########## @@ -131,21 +139,21 @@ static void ping_result(FAR const struct ping_result_s *result) break; case ICMP_E_SENDTO: - fprintf(stderr, "ERROR: sendto failed at seqno %u: %d\n", + fprintf(stderr, "ERROR: sendto failed at seqno %u: %ld\n", Review comment: @davids5 we don't need apply PRI macro to uint16_t, since C standard require all type which's size is small than [unsigned]int must be promote to [unsigned]int for vararg function. @wenliangxue please revert all seqno related change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org