acassis commented on a change in pull request #5895:
URL: https://github.com/apache/incubator-nuttx/pull/5895#discussion_r836742040



##########
File path: boards/Board.mk
##########
@@ -30,12 +30,12 @@ $(RCOBJS): $(ETCDIR)$(DELIM)%: %
        $(Q) mkdir -p $(dir $@)
        $(call PREPROCESS, $<, $@)
 
-$(ETCSRC): $(RCRAWS) $(RCOBJS)
+$(ETCSRC): $(addprefix $(BOARD_DIR)$(DELIM)src$(DELIM),$(RCRAWS)) $(RCOBJS)
        $(foreach raw, $(RCRAWS), \
          $(shell rm -rf $(ETCDIR)$(DELIM)$(raw)) \
          $(shell mkdir -p $(dir $(ETCDIR)$(DELIM)$(raw))) \
-         $(shell cp -rfp $(raw) $(ETCDIR)$(DELIM)$(raw)))
-       $(Q) genromfs -f romfs.img -d 
$(ETCDIR)$(DELIM)$(CONFIG_NSH_ROMFSMOUNTPT) -V "$(basename $<)"
+         $(shell cp -rfp $(BOARD_DIR)$(DELIM)src$(DELIM)$(raw) 
$(ETCDIR)$(DELIM)$(raw)))
+       $(Q) genromfs -f romfs.img -d 
$(ETCDIR)$(DELIM)$(CONFIG_NSH_ROMFSMOUNTPT) -V "NSHInitVol"

Review comment:
       Doing a git grep for CONFIG_NSH_ROMFSETC show it is more common, maybe 
all defconfigs should me modified to use CONFIG_NSH_ROMFSMOUNTPT, what do you 
think?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to