pkarashchenko commented on a change in pull request #5895:
URL: https://github.com/apache/incubator-nuttx/pull/5895#discussion_r836798231



##########
File path: boards/Board.mk
##########
@@ -30,12 +30,12 @@ $(RCOBJS): $(ETCDIR)$(DELIM)%: %
        $(Q) mkdir -p $(dir $@)
        $(call PREPROCESS, $<, $@)
 
-$(ETCSRC): $(RCRAWS) $(RCOBJS)
+$(ETCSRC): $(addprefix $(BOARD_DIR)$(DELIM)src$(DELIM),$(RCRAWS)) $(RCOBJS)
        $(foreach raw, $(RCRAWS), \
          $(shell rm -rf $(ETCDIR)$(DELIM)$(raw)) \
          $(shell mkdir -p $(dir $(ETCDIR)$(DELIM)$(raw))) \
-         $(shell cp -rfp $(raw) $(ETCDIR)$(DELIM)$(raw)))
-       $(Q) genromfs -f romfs.img -d 
$(ETCDIR)$(DELIM)$(CONFIG_NSH_ROMFSMOUNTPT) -V "$(basename $<)"
+         $(shell cp -rfp $(BOARD_DIR)$(DELIM)src$(DELIM)$(raw) 
$(ETCDIR)$(DELIM)$(raw)))
+       $(Q) genromfs -f romfs.img -d 
$(ETCDIR)$(DELIM)$(CONFIG_NSH_ROMFSMOUNTPT) -V "NSHInitVol"

Review comment:
       > I think someone added CONFIG_NSH_ROMFSMOUNTPT but we already have 
CONFIG_NSH_ROMFSETC that seams to fit the same purpose
   
   `CONFIG_NSH_ROMFSETC` is a `bool` option to `Mount a ROMFS filesystem at` 
`CONFIG_NSH_ROMFSMOUNTPT` path (that is a string defaulted to `/etc`)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to