gustavonihei commented on a change in pull request #5827:
URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r836800236
##########
File path: arch/xtensa/src/esp32s2/Kconfig
##########
@@ -92,14 +92,16 @@ config ESP32S2_INSTRUCTION_CACHE_LINE_SIZE
choice ESP32S2_DATA_CACHE_SIZE
prompt "Data cache size"
- default ESP32S2_DATA_CACHE_0KB
+ default ESP32S2_DATA_CACHE_0KB if !ESP32S2_SPIRAM
+ default ESP32S2_DATA_CACHE_8KB if ESP32S2_SPIRAM
Review comment:
Data cache initialization is still missing and it should be added to the
CPU initialization routine:
https://github.com/apache/incubator-nuttx/blob/master/arch/xtensa/src/esp32s2/esp32s2_start.c#L177-L209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
