gustavonihei commented on a change in pull request #5827:
URL: https://github.com/apache/incubator-nuttx/pull/5827#discussion_r838057584



##########
File path: arch/xtensa/src/esp32s2/esp32s2_start.c
##########
@@ -110,6 +111,9 @@ typedef enum
   CACHE_LINE_SIZE_64B = 2,            /* 64 Byte cache line size */
 } cache_line_size_t;
 
+#define CACHE_SIZE_8KB  CACHE_SIZE_HALF
+#define CACHE_SIZE_16KB CACHE_SIZE_FULL

Review comment:
       There is no need to create these definitions. Just another indirection 
that adds little to code comprehension.
   The use of `cache_size_t` enum itens is already conditioned by ifdefs for 
8KB and 16KB.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to