pussuw commented on code in PR #5985:
URL: https://github.com/apache/incubator-nuttx/pull/5985#discussion_r844722573
##########
arch/risc-v/src/common/riscv_percpu.c:
##########
@@ -86,13 +92,39 @@ void riscv_percpu_init(void)
void riscv_percpu_add_hart(uintptr_t hartid)
{
- /* Hart IDs go from 0...4 */
+ riscv_percpu_t *percpu;
+ uintptr_t stack_top;
+
+ /* Get free entry for this hart, this must not fail */
+
+ percpu = (riscv_percpu_t *)sq_remfirst(&g_freelist);
+ DEBUGASSERT(percpu);
+
+ /* Get interrupt stack (if any) */
+
+ stack_top = 0;
Review Comment:
Both assignments are dependent on this:
`#if CONFIG_ARCH_INTERRUPTSTACK > 15`
Which means this:
`percpu->irq_stack = stack_top;`
Would use an uninitialized value.
I can of course remove the temp variable altogether, but to me this current
implementation is fine too (need to fix the bug below).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
