raiden00pl commented on PR #6057:
URL: https://github.com/apache/incubator-nuttx/pull/6057#issuecomment-1100247303

   > I had it split out into smaller pieces, but @xiaoxiang781216 requested I 
consolidate them into one commit. Should I split it back out?
   
   Sorry, I but I didn't see the previous version. But I think we shouldn't 
combine:
   
   1. stm32h7 specific driver implementation
   2. changes related to general SocketCAN interface
   3. fixes for flexcan implementation related to point 2
   
   At least 1 should be separated from 2 and 3.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to