xiaoxiang781216 commented on code in PR #6069: URL: https://github.com/apache/incubator-nuttx/pull/6069#discussion_r852656317
########## arch/risc-v/src/common/riscv_addrenv_util.c: ########## @@ -0,0 +1,57 @@ +/**************************************************************************** + * arch/risc-v/src/common/riscv_addrenv_util.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <arch/board/board_memorymap.h> + +#include "pgalloc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: riscv_pgpool_to_vaddr + * + * Description: + * Convert physical page pool address to virtual page pool address + * + * Input Parameters: + * paddr - The physical address to convert + * + * Returned Value: + * Page pool virtual address, or 0 if paddr is not within page pool + * + ****************************************************************************/ + +uintptr_t riscv_pgpool_to_vaddr(uintptr_t paddr) Review Comment: But ARCH_PGPOOL_PBASE is defined in arch/Kconfig, and then shared by all arch(both arm and riscv), which mean the user could change the setting through ARCH_PGPOOL_PBASE, but you ignore it totally. It isn't good. As I suggest before, if you think other arch implementation isn't good enough and you have good idea to improve it. Please improve other arch first, otherwise follow the old implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
