pussuw commented on code in PR #6069: URL: https://github.com/apache/incubator-nuttx/pull/6069#discussion_r852670589
########## arch/risc-v/src/common/riscv_addrenv_util.c: ########## @@ -0,0 +1,57 @@ +/**************************************************************************** + * arch/risc-v/src/common/riscv_addrenv_util.c + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. The + * ASF licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the + * License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations + * under the License. + * + ****************************************************************************/ + +/**************************************************************************** + * Included Files + ****************************************************************************/ + +#include <nuttx/config.h> + +#include <arch/board/board_memorymap.h> + +#include "pgalloc.h" + +/**************************************************************************** + * Public Functions + ****************************************************************************/ + +/**************************************************************************** + * Name: riscv_pgpool_to_vaddr + * + * Description: + * Convert physical page pool address to virtual page pool address + * + * Input Parameters: + * paddr - The physical address to convert + * + * Returned Value: + * Page pool virtual address, or 0 if paddr is not within page pool + * + ****************************************************************************/ + +uintptr_t riscv_pgpool_to_vaddr(uintptr_t paddr) Review Comment: > For example, the implementation of fputest isn't good, @anchao(#6080) provide a patch not only fix arm, but also riscv. We need consider the project as whole and all components equally, and improve them together as much as we can. Another example, you find address environment issue which is fixed by #5913, even we never use the kernel mode in the production, but we still take additional time to bring the change back to other arch: #6089, #6089 and #6099. Yes I think it's great you are patching both platforms, and especially the unifying work under risc-v that has removed a massive amount of copy & paste is fantastic. But please keep in mind, I'm doing this on my own and not capable of doing as much as you guys. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
