JacobCrabill commented on code in PR #6057: URL: https://github.com/apache/incubator-nuttx/pull/6057#discussion_r860002694
########## include/nuttx/net/ioctl.h: ########## @@ -112,8 +112,12 @@ /* SocketCAN ****************************************************************/ -#define SIOCGCANBITRATE _SIOC(0x002C) /* Get bitrate from a CAN controller */ -#define SIOCSCANBITRATE _SIOC(0x002D) /* Set bitrate of a CAN controller */ +#define SIOCGCANBITRATE _SIOC(0x002C) /* Get bitrate from a CAN controller */ +#define SIOCSCANBITRATE _SIOC(0x002D) /* Set bitrate of a CAN controller */ +#define SIOCACANEXTFILTER _SIOC(0x002E) /* Add hardware-level exteneded ID filter */ Review Comment: Correct, there's been a lot of discussion between a few PX4 developers around HW-level filtering of CAN IDs, exactly as @PetervdPerk-NXP said. Since other CAN drivers in NuttX (the character-device drivers) have ioctl's for adding/removing filters, it made sense to me to do the same here in a way that would preserve the existing SocketCAN functionality / API, while adding extra features for those who want it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
