xiaoxiang781216 commented on code in PR #6251: URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r871448752
########## arch/arm/src/c5471/c5471_ethernet.c: ########## @@ -1892,7 +1892,7 @@ static int c5471_ifup(struct net_driver_s *dev) putreg32((getreg32(EIM_CTRL) | EIM_CTRL_ESM_EN), EIM_CTRL); /* enable ESM */ putreg32((getreg32(ENET0_MODE) | ENET_MODE_ENABLE), ENET0_MODE); /* enable ENET */ - up_mdelay(100); + nxsig_usleep(100000); Review Comment: Yes, that's why I just modify the sleep time >= 10ms, since the default tick is 10ms in tick mode: https://github.com/apache/incubator-nuttx/blob/master/sched/Kconfig#L89-L92 It's hard to imagine that it's good to busy loop more than 10ms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
