davids5 commented on code in PR #6251: URL: https://github.com/apache/incubator-nuttx/pull/6251#discussion_r872189901
########## arch/arm/src/lpc43xx/lpc43_cgu.c: ########## @@ -654,7 +654,7 @@ void lpc43_clockconfig(void) /* Delay around 10 milliseconds */ - up_mdelay(XTAL_DELAY); + nxsig_usleep(XTAL_DELAY); Review Comment: I agree 100% - If this PR is to come in, every change needs to be checked for where it is run from. i.e. what stage is the system in and if the delay was uninterruptable for HW timing requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
