xiaoxiang781216 commented on code in PR #6328: URL: https://github.com/apache/incubator-nuttx/pull/6328#discussion_r882749330
########## sched/task/exit.c: ########## @@ -68,12 +67,6 @@ void _exit(int status) group_kill_children(tcb); #endif -#if !defined(CONFIG_DISABLE_PTHREAD) && !defined(CONFIG_PTHREAD_MUTEX_UNSAFE) Review Comment: > Yes, but `nxtask_exithook` is called from `nxtask_terminate` that is called from: > > * `nxtask_exit` > * `nxtask_delete` > So now `pthread_mutex_inconsistent` will be called from that context as well. > Additionally `nxtask_recover` is called from `nxtask_restart`, so `pthread_mutex_inconsistent` will be called there as well. Yes, since all above functions should release the mutex which forget to release. > Just want to make sure that all that cases are impacted intentionally and have been verified. Sure, it's always good to ensure all side effect get confirmed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
