xiaoxiang781216 commented on code in PR #6328:
URL: https://github.com/apache/incubator-nuttx/pull/6328#discussion_r882782750


##########
sched/task/exit.c:
##########
@@ -68,12 +67,6 @@ void _exit(int status)
   group_kill_children(tcb);
 #endif
 
-#if !defined(CONFIG_DISABLE_PTHREAD) && !defined(CONFIG_PTHREAD_MUTEX_UNSAFE)

Review Comment:
   > Yes. I think that initial approach was covering `pthread` cases only, but 
this enables usage of `pthread_mutex` on task level.
   
   Yes, all pthread api can be used in main thread too.
   
   
   > I mean that "Impact" is stated as "Code refactor", but in fact it is 
change of functionality
   
   Ok, Impact is updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to