xiaoxiang781216 commented on code in PR #6482: URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r903982091
########## include/endian.h: ########## @@ -52,21 +52,50 @@ /* Common byte swapping macros */ #define __SWAP_UINT16_ISMACRO 1 -#undef __SWAP_UINT32_ISMACRO +#define __SWAP_UINT32_ISMACRO 1 +#define __SWAP_UINT64_ISMACRO 1 Review Comment: let's remove all __SWAP_UINTXX_ISMACRO and libs/libc/endian/lib_swapxx.c? it doesn't make sense to keep them if we always enable the macro version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
