[GitHub] [incubator-nuttx] nimish commented on a diff in pull request #6482: Use builtins for byteswapping

[GitBox]

nimish commented on code in PR #6482:
URL: https://github.com/apache/incubator-nuttx/pull/6482#discussion_r906397250


##########
libs/libc/string/lib_ffsll.c:
##########
@@ -57,10 +57,12 @@ int ffsll(long long j)
 
   if (j != 0)
     {
-#ifdef CONFIG_HAVE_BUILTIN_CTZ
+#ifdef CONFIG_HAVE_BUILTIN_FFSLL
+      ret = __builtin_ffs(j);

Review Comment:
   yep



##########
libs/libc/string/lib_ffsl.c:
##########
@@ -48,14 +48,15 @@
  *   0, then ffsl() will return 0.
  *
  ****************************************************************************/
-
 int ffsl(long j)
 {
   int ret = 0;
 
   if (j != 0)
     {
-#ifdef CONFIG_HAVE_BUILTIN_CTZ
+#ifdef CONFIG_HAVE_BUILTIN_FFSL
+      ret = __builtin_ffs(j);

Review Comment:
   yep



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org