xiaoxiang781216 commented on code in PR #6850:
URL: https://github.com/apache/incubator-nuttx/pull/6850#discussion_r946692251
##########
drivers/wireless/ieee80211/bcm43xxx/Kconfig:
##########
@@ -40,6 +40,35 @@ config IEEE80211_INFINEON_CYW43439
default n
select IEEE80211_BROADCOM_HAVE_CLM
+config CYW43439_FIRMWARE_BIN_PATH
+ string "Path to Infineon 43439 firmware file"
+ depends on IEEE80211_INFINEON_CYW43439
+ default
"${PICO_SDK_PATH}/lib/cyw43-driver/firmware/43439A0-7.95.49.00.combined"
+ ---help---
+ This should be a path to a file containing both the cyw43439
firmware and
+ the CLB blob. The firmware should be padded to a 256 byte
boundary and
+ then the CLM blob should be appended.
+
+ If this file is updated, check the CYW43439_FIRMWARE_LEN and
+ CYW43439_CLM_BLOB_LEN below to make sure they reflect the new,
un-padded
+ lengths of the two parts.
+
+config CYW43439_FIRMWARE_LEN
Review Comment:
why not pass len by gobal variable?
##########
drivers/.gitignore:
##########
@@ -1 +1,2 @@
/platform
+*.image
Review Comment:
revert the change
##########
drivers/wireless/ieee80211/bcm43xxx/cyw_chip_43439.c:
##########
@@ -37,15 +37,19 @@
* Public Data
****************************************************************************/
-extern const char cyw43439_nvram_image[];
-extern const unsigned int cyw43439_nvram_image_len;
+extern const uint8_t g_cyw43439_nvram_image[];
+extern unsigned int g_cyw43439_nvram_len;
#ifndef CONFIG_IEEE80211_BROADCOM_FWFILES
-extern const uint8_t cyw43439_firmware_image[];
Review Comment:
let's use the consistent naming for bcm chip too.(either has or not g_).
##########
drivers/wireless/ieee80211/bcm43xxx/Kconfig:
##########
@@ -40,6 +40,35 @@ config IEEE80211_INFINEON_CYW43439
default n
select IEEE80211_BROADCOM_HAVE_CLM
+config CYW43439_FIRMWARE_BIN_PATH
+ string "Path to Infineon 43439 firmware file"
+ depends on IEEE80211_INFINEON_CYW43439
+ default
"${PICO_SDK_PATH}/lib/cyw43-driver/firmware/43439A0-7.95.49.00.combined"
+ ---help---
+ This should be a path to a file containing both the cyw43439
firmware and
+ the CLB blob. The firmware should be padded to a 256 byte
boundary and
+ then the CLM blob should be appended.
+
+ If this file is updated, check the CYW43439_FIRMWARE_LEN and
+ CYW43439_CLM_BLOB_LEN below to make sure they reflect the new,
un-padded
+ lengths of the two parts.
+
+config CYW43439_FIRMWARE_LEN
+ int "Infineon 43439 firmware length (bytes)"
+ depends on IEEE80211_INFINEON_CYW43439
+ default 224190
+ ---help---
+ This is the length of the base firmware in the firmware file
specified
+ by the "Path to Infineon 43439 firmware file" configuration
option.
+
+config CYW43439_CLM_BLOB_LEN
+ int "Infineon 43439 clm blob length (bytes)"
+ depends on IEEE80211_INFINEON_CYW43439
+ default 984
Review Comment:
ditto
##########
drivers/Makefile:
##########
@@ -82,7 +82,7 @@ OBJS = $(AOBJS) $(COBJS)
BIN = libdrivers$(LIBEXT)
-all: $(BIN)
+all:
Review Comment:
revert
##########
drivers/wireless/ieee80211/bcm43xxx/Kconfig:
##########
@@ -40,6 +40,35 @@ config IEEE80211_INFINEON_CYW43439
default n
select IEEE80211_BROADCOM_HAVE_CLM
+config CYW43439_FIRMWARE_BIN_PATH
+ string "Path to Infineon 43439 firmware file"
+ depends on IEEE80211_INFINEON_CYW43439
+ default
"${PICO_SDK_PATH}/lib/cyw43-driver/firmware/43439A0-7.95.49.00.combined"
Review Comment:
let's move to your board file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
