xiaoxiang781216 commented on code in PR #6850:
URL: https://github.com/apache/incubator-nuttx/pull/6850#discussion_r947420814
##########
drivers/wireless/ieee80211/bcm43xxx/cyw_chip_43439.c:
##########
@@ -70,18 +75,16 @@ const struct bcmf_chip_data cyw43439_config_data =
/* Firmware images */
- /* TODO find something smarter than using image_len references */
-
- .nvram_image = (FAR uint8_t *)cyw43439_nvram_image,
- .nvram_image_size = (FAR unsigned int *)&cyw43439_nvram_image_len,
+ .nvram_image = (FAR uint8_t *) g_cyw43439_nvram_image,
+ .nvram_image_size = (FAR unsigned int *) &g_cyw43439_nvram_len,
#ifndef CONFIG_IEEE80211_BROADCOM_FWFILES
- .firmware_image = (FAR uint8_t *)cyw43439_firmware_image,
- .firmware_image_size = (FAR unsigned int *)&cyw43439_firmware_len,
+ .firmware_image = (FAR uint8_t *) g_cyw43439_firmware_image,
+ .firmware_image_size = (FAR unsigned int *) &g_cyw43439_firmware_len,
#ifdef CONFIG_IEEE80211_BROADCOM_HAVE_CLM
- .clm_blob_image = (FAR uint8_t *)cyw43439_clm_blob_image,
- .clm_blob_image_size = (FAR unsigned int *)&cyw43439_clm_blob_len
+ .clm_blob_image = (FAR uint8_t *) g_cyw43439_clm_blob_image,
+ .clm_blob_image_size = (FAR unsigned int *) &g_cyw43439_clm_blob_len
Review Comment:
remove the space after all cast
##########
arch/arm/src/rp2040/Kconfig:
##########
@@ -685,6 +685,7 @@ config RP2040_BOARD_HAS_WS2812
bool "Has ws2812 pixels"
default n
depends on WS2812
+ select WS2812_NON_SPI_DRIVER
Review Comment:
tab
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
