nealef commented on PR #7025:
URL: https://github.com/apache/incubator-nuttx/pull/7025#issuecomment-1239081275

   Please elaborate.
   
   
   -------- Original message --------
   From: Petro Karashchenko ***@***.***>
   Date: 9/7/22 18:26 (GMT+10:00)
   To: apache/incubator-nuttx ***@***.***>
   Cc: Neale Ferguson ***@***.***>, Mention ***@***.***>
   Subject: Re: [apache/incubator-nuttx] Add check in roundx() functions for 
infinite or NaN cases (PR #7025)
   
   
   @pkarashchenko commented on this pull request.
   
   ________________________________
   
   In 
libs/libc/math/lib_round.c<https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964541655>:
   
   > @@ -34,6 +34,11 @@
    #ifdef CONFIG_HAVE_DOUBLE
    double round(double x)
    {
   +  if (isinf(x) || isnan(x))
   +    {
   +      return (x);
   +    }
   +
      double f = modf(x, &x);
   
   
   please address this. It is C89 incompliant
   
   —
   Reply to this email directly, view it on 
GitHub<https://github.com/apache/incubator-nuttx/pull/7025#discussion_r964541655>,
 or 
unsubscribe<https://github.com/notifications/unsubscribe-auth/AACLN6XRFXES7N2J66TXABLV5BGTZANCNFSM6AAAAAAQGKMO7E>.
   You are receiving this because you were mentioned.Message ID: ***@***.***>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to