xiaoxiang781216 commented on code in PR #7025: URL: https://github.com/apache/incubator-nuttx/pull/7025#discussion_r965481372
########## include/nuttx/lib/math.h: ########## @@ -81,11 +81,17 @@ #define INFINITY_F (1.0F/0.0F) #define NAN_F (0.0F/0.0F) +#define INFINITY_L (1.0F/0.0L) +#define NAN_L (0.0F/0.0L) + Review Comment: > I will fix. When I squash should it be `git rebase -i 94cf99f310409f8c86681a0ee7177f2bbfeaa24a` which seems to mean I will squash my just squashed commit and this new one? Yes, git rebase -i work correctly. > Are you sure it's not easier from github? If we use github merge, it will generate the commit message automatically by accumulating individual commit message which may not good as expect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
