[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7160: arch: Change the linker generated symbols from uint32_t to uint8_t *

[GitBox]

xiaoxiang781216 commented on code in PR #7160:
URL: https://github.com/apache/incubator-nuttx/pull/7160#discussion_r977926943


##########
arch/arm/src/cxd56xx/cxd56_allocateheap.c:
##########
@@ -115,7 +115,7 @@ void up_allocate_heap(void **heap_start, size_t *heap_size)
 
   board_autoled_on(LED_HEAPALLOCATE);
   *heap_start = (void *)g_idle_topstack;
-  *heap_size = (uint32_t)&__stack - g_idle_topstack;
+  *heap_size = (uint32_t)__stack - g_idle_topstack;

Review Comment:
   Can't, since the type is different(uint8_t * v.s. uintptr_t).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org