[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7160: arch: Change the linker generated symbols from uint32_t to uint8_t *

[GitBox]

xiaoxiang781216 commented on code in PR #7160:
URL: https://github.com/apache/incubator-nuttx/pull/7160#discussion_r977928942


##########
arch/arm/src/rtl8720c/ameba_nvic.c:
##########
@@ -316,7 +316,7 @@ void up_irqinitialize(void)
 
   /* Restore the NVIC vector location to local */
 
-  memcpy(&__vectors, (void *) * (volatile uint32_t *)(NVIC_VECTAB)
+  memcpy(__vectors, (void *) * (volatile uint32_t *)(NVIC_VECTAB)

Review Comment:
   No, __vectors is an array defined at line 63:
   ```
   static int (* __vectors[NR_IRQS - NVIC_IRQ_FIRST])(void);
   ```
   not a link symbol.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org