pkarashchenko commented on code in PR #6965:
URL: https://github.com/apache/incubator-nuttx/pull/6965#discussion_r991890244
##########
arch/arm/src/stm32h7/stm32_serial.c:
##########
@@ -3347,7 +3352,7 @@ static void up_dma_txcallback(DMA_HANDLE handle, uint8_t
status, void *arg)
/* Start transmission with the callback on DMA completion */
stm32_dmastart(priv->txdma, up_dma_txcallback,
- (void *)priv, false);
+ priv, false);
Review Comment:
```suggestion
priv, false);
```
##########
arch/arm/src/stm32f0l0g0/stm32_serial_v1.c:
##########
@@ -1272,7 +1272,7 @@ static int stm32serial_dmasetup(struct uart_dev_s *dev)
*/
stm32_dmastart(priv->rxdma, stm32serial_dmarxcallback,
- (void *)priv, false);
+ priv, false);
Review Comment:
```suggestion
priv, false);
```
##########
arch/arm/src/imxrt/imxrt_lpi2c.c:
##########
@@ -1145,7 +1070,7 @@ static void imxrt_lpi2c_setclock(struct
imxrt_lpi2c_priv_s *priv,
CCM_CSCDR2_LPI2C_CLK_PODF_SHIFT;
lpi2c_clk_div = lpi2c_clk_div + 1;
src_freq = (BOARD_XTAL_FREQUENCY * pll3_div) /
- (8 * lpi2c_clk_div) ;
+ (8 * lpi2c_clk_div) ;
Review Comment:
```suggestion
(8 * lpi2c_clk_div);
```
##########
drivers/audio/wm8994.c:
##########
@@ -1727,7 +1711,7 @@ static int wm8994_interrupt(FAR const struct
wm8994_lower_s *lower,
static void *wm8994_workerthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *wm8994_workerthread(pthread_addr_t pvarg)
```
##########
drivers/mtd/w25qxxxjv.c:
##########
@@ -566,7 +566,7 @@ static void w25qxxxjv_write_status(FAR struct
w25qxxxjv_dev_s *priv)
priv->cmdbuf[0] &= ~STATUS_SRP_MASK;
w25qxxxjv_command_write(priv->qspi, W25QXXXJV_WRITE_STATUS_1,
- (FAR const void *)priv->cmdbuf, 1);
+ priv->cmdbuf, 1);
Review Comment:
```suggestion
priv->cmdbuf, 1);
```
##########
drivers/wireless/ieee802154/at86rf23x/at86rf23x.c:
##########
@@ -725,7 +725,7 @@ static int at86rf23x_setpanid(FAR struct ieee802154_radio_s
*ieee,
uint16_t panid)
{
FAR struct at86rf23x_dev_s *dev = (struct at86rf23x_dev_s *)ieee;
Review Comment:
```suggestion
FAR struct at86rf23x_dev_s *dev = (FAR struct at86rf23x_dev_s *)ieee;
```
##########
drivers/mtd/n25qxxx.c:
##########
@@ -543,7 +543,7 @@ static void n25qxxx_write_volcfg(FAR struct n25qxxx_dev_s
*priv)
{
n25qxxx_write_enable(priv);
n25qxxx_command_write(priv->qspi, N25QXXX_WRITE_VOLCFG,
- (FAR const void *)priv->cmdbuf, 1);
+ priv->cmdbuf, 1);
Review Comment:
```suggestion
priv->cmdbuf, 1);
```
##########
drivers/wireless/ieee802154/at86rf23x/at86rf23x.c:
##########
@@ -745,7 +745,7 @@ static int at86rf23x_getpanid(FAR struct ieee802154_radio_s
*ieee,
FAR uint16_t *panid)
{
FAR struct at86rf23x_dev_s *dev = (struct at86rf23x_dev_s *)ieee;
Review Comment:
```suggestion
FAR struct at86rf23x_dev_s *dev = (FAR struct at86rf23x_dev_s *)ieee;
```
##########
drivers/wireless/gs2200m.c:
##########
@@ -910,7 +892,7 @@ enum spi_status_e gs2200m_hal_write(FAR struct
gs2200m_dev_s *dev,
const void *data,
uint16_t txlen)
{
- uint8_t *tx = (uint8_t *)data;
+ uint8_t *tx = (FAR uint8_t *)data;
Review Comment:
```suggestion
FAR uint8_t *tx = (FAR uint8_t *)data;
```
##########
net/sixlowpan/sixlowpan_input.c:
##########
@@ -724,7 +724,7 @@ static int sixlowpan_dispatch(FAR struct radio_driver_s
*radio)
****************************************************************************/
int sixlowpan_input(FAR struct radio_driver_s *radio,
- FAR struct iob_s *framelist, FAR const void *metadata)
+ FAR struct iob_s *framelist, FAR const void *metadata)
{
int ret = -EINVAL;
uint8_t *d_buf_backup;
Review Comment:
```suggestion
FAR uint8_t *d_buf_backup;
```
##########
wireless/bluetooth/bt_smp.c:
##########
@@ -1035,7 +1035,7 @@ static uint8_t smp_ident_addr_info(FAR struct bt_conn_s
*conn,
if (bt_addr_le_is_rpa(&conn->dst))
{
- bt_addr_copy(&keys->irk.rpa, (bt_addr_t *) & conn->dst.val);
+ bt_addr_copy(&keys->irk.rpa, (bt_addr_t *)&conn->dst.val);
Review Comment:
```suggestion
bt_addr_copy(&keys->irk.rpa, (FAR bt_addr_t *)&conn->dst.val);
```
##########
drivers/audio/wm8776.c:
##########
@@ -1179,7 +1122,7 @@ static void wm8776_hw_reset(FAR struct wm8776_dev_s *priv)
static void *wm8776_workerthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *wm8776_workerthread(pthread_addr_t pvarg)
```
##########
drivers/video/video.c:
##########
@@ -3209,7 +3180,7 @@ static int video_complete_capture(uint8_t err_code,
uint32_t datasize)
}
else
{
- g_video_data_ops->set_buf((uint8_t *)container->buf.m.userptr,
+ g_video_data_ops->set_buf((FAR uint8_t *)container->buf.m.userptr,
container->buf.length);
Review Comment:
```suggestion
container->buf.length);
```
##########
drivers/audio/wm8904.c:
##########
@@ -2090,7 +2035,7 @@ static int wm8904_interrupt(FAR const struct
wm8904_lower_s *lower,
static void *wm8904_workerthread(pthread_addr_t pvarg)
Review Comment:
```suggestion
static FAR void *wm8904_workerthread(pthread_addr_t pvarg)
```
##########
arch/arm/src/stm32wl5/stm32wl5_serial.c:
##########
@@ -1327,7 +1327,7 @@ static int stm32wl5serial_dmasetup(struct uart_dev_s *dev)
*/
stm32wl5_dmastart(priv->rxdma, stm32wl5serial_dmarxcallback,
- (void *)priv, true);
+ priv, true);
Review Comment:
```suggestion
priv, true);
```
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi.c:
##########
@@ -339,7 +339,7 @@ static int bcmf_gspi_bus_lowpower(FAR bcmf_gspi_dev_t
*gbus, bool enable)
static int bcmf_gspi_thread_isr(int isr, void *context, void *arg)
Review Comment:
```suggestion
static int bcmf_gspi_thread_isr(int isr, FAR void *context, FAR void *arg)
```
##########
fs/rpmsgfs/rpmsgfs.c:
##########
@@ -77,7 +78,7 @@ struct rpmsgfs_ofile_s
struct rpmsgfs_mountpt_s
{
- sem_t fs_sem; /* Assure thread-safe access */
+ mutex_t fs_lock; /* Assure thread-safe access */
FAR struct rpmsgfs_ofile_s *fs_head; /* Singly-linked list of open files */
char fs_root[PATH_MAX];
void *handle;
Review Comment:
```suggestion
FAR void *handle;
```
##########
drivers/wireless/gs2200m.c:
##########
@@ -910,7 +892,7 @@ enum spi_status_e gs2200m_hal_write(FAR struct
gs2200m_dev_s *dev,
const void *data,
Review Comment:
```suggestion
FAR const void *data,
```
##########
net/can/can_recvmsg.c:
##########
@@ -231,7 +231,7 @@ static inline void can_newdata(FAR struct net_driver_s *dev,
static inline int can_readahead(struct can_recvfrom_s *pstate)
Review Comment:
```suggestion
static inline int can_readahead(FAR struct can_recvfrom_s *pstate)
```
##########
drivers/wireless/ieee802154/at86rf23x/at86rf23x.c:
##########
@@ -766,7 +766,7 @@ static int at86rf23x_setsaddr(FAR struct ieee802154_radio_s
*ieee,
uint16_t saddr)
{
FAR struct at86rf23x_dev_s *dev = (struct at86rf23x_dev_s *)ieee;
Review Comment:
```suggestion
FAR struct at86rf23x_dev_s *dev = (FAR struct at86rf23x_dev_s *)ieee;
```
##########
drivers/wireless/ieee80211/bcm43xxx/bcmf_gspi_f2_frame.c:
##########
@@ -145,13 +145,12 @@ int process_f2_frame_header(FAR bcmf_interface_dev_t
*gbus,
int bcmf_gspi_read_f2_frame(FAR struct bcmf_dev_s *priv,
int frame_length)
{
- FAR bcmf_gspi_dev_t *gbus = (FAR bcmf_gspi_dev_t *)priv->bus;
- FAR gspi_dev_t *gspi = gbus->gspi;
-
- bcmf_interface_frame_t *iframe;
- f2_frame_header_t *header;
- int ret;
- uint16_t checksum;
+ FAR bcmf_gspi_dev_t *gbus = (FAR bcmf_gspi_dev_t *)priv->bus;
+ FAR gspi_dev_t *gspi = gbus->gspi;
+ FAR bcmf_interface_frame_t *iframe;
+ f2_frame_header_t *header;
Review Comment:
```suggestion
FAR f2_frame_header_t *header;
```
##########
drivers/wireless/ieee802154/at86rf23x/at86rf23x.c:
##########
@@ -786,7 +786,7 @@ static int at86rf23x_getsaddr(FAR struct ieee802154_radio_s
*ieee,
FAR uint16_t *saddr)
{
FAR struct at86rf23x_dev_s *dev = (struct at86rf23x_dev_s *)ieee;
Review Comment:
```suggestion
FAR struct at86rf23x_dev_s *dev = (FAR struct at86rf23x_dev_s *)ieee;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
