pkarashchenko commented on code in PR #7855: URL: https://github.com/apache/nuttx/pull/7855#discussion_r1047644661
########## arch/xtensa/src/common/xtensa_hostfs.c: ########## @@ -204,7 +204,7 @@ int host_unlink(const char *pathname) return -ENOSYS; } -int host_mkdir(const char *pathname, mode_t mode) +int host_mkdir(const char *pathname, int mode) Review Comment: why `int` here and not `nuttx_mode_t`? ########## arch/risc-v/src/common/riscv_hostfs.c: ########## @@ -297,7 +297,7 @@ int host_unlink(const char *pathname) return host_call(HOST_REMOVE, &remove, sizeof(remove)); } -int host_mkdir(const char *pathname, mode_t mode) +int host_mkdir(const char *pathname, int mode) Review Comment: why `int` and not `nuttx_mode_t`? ########## arch/arm/src/common/arm_hostfs.c: ########## @@ -297,7 +297,7 @@ int host_unlink(const char *pathname) return host_call(HOST_REMOVE, &remove, sizeof(remove)); } -int host_mkdir(const char *pathname, mode_t mode) +int host_mkdir(const char *pathname, int mode) Review Comment: why `int` here and not `nuttx_mode_t`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
