xiaoxiang781216 commented on code in PR #7855: URL: https://github.com/apache/nuttx/pull/7855#discussion_r1047965134
########## arch/xtensa/src/common/xtensa_hostfs.c: ########## @@ -204,7 +204,7 @@ int host_unlink(const char *pathname) return -ENOSYS; } -int host_mkdir(const char *pathname, mode_t mode) +int host_mkdir(const char *pathname, int mode) Review Comment: hostfs implementation on other platforms can reference nuttx header files directly without conflict, but sim can't do the same thing because there is huge conflict between host's libc and nuttx's. Please check the code guarded by __SIM__ macro in include/nuttx/fs/hostfs.h. ########## arch/xtensa/src/common/xtensa_hostfs.c: ########## @@ -204,7 +204,7 @@ int host_unlink(const char *pathname) return -ENOSYS; } -int host_mkdir(const char *pathname, mode_t mode) +int host_mkdir(const char *pathname, int mode) Review Comment: hostfs implementation on other platforms can reference nuttx header files directly without conflict, but sim can't do the same thing because there is huge conflict between host's libc and nuttx's. Please check the code guarded by __SIM__ macro in include/nuttx/fs/hostfs.h. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
