xiaoxiang781216 commented on code in PR #7841:
URL: https://github.com/apache/nuttx/pull/7841#discussion_r1049702953
##########
drivers/note/Make.defs:
##########
@@ -19,11 +19,10 @@
############################################################################
ifeq ($(CONFIG_DRIVER_NOTE),y)
- ifeq ($(CONFIG_SCHED_INSTRUMENTATION_EXTERNAL),)
Review Comment:
since not all drivers convert to the new style,
SCHED_INSTRUMENTATION_EXTERNAL need keep as before.
##########
drivers/note/Make.defs:
##########
@@ -19,11 +19,10 @@
############################################################################
ifeq ($(CONFIG_DRIVER_NOTE),y)
- ifeq ($(CONFIG_SCHED_INSTRUMENTATION_EXTERNAL),)
- CSRCS += note_driver.c
- CFLAGS += ${INCDIR_PREFIX}${TOPDIR}/sched
- endif
+ CSRCS += note_driver.c
CSRCS += note_initialize.c
+ CFLAGS += ${INCDIR_PREFIX}${TOPDIR}/note
Review Comment:
why need add drivers/note to search path
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
