xiaoxiang781216 commented on code in PR #7841:
URL: https://github.com/apache/nuttx/pull/7841#discussion_r1049910166


##########
include/nuttx/note/note_driver.h:
##########
@@ -35,6 +36,56 @@
  * Public Types
  ****************************************************************************/
 
+struct note_driver_s;
+
+struct note_driver_ops_s
+{
+  CODE void (*write)(FAR struct note_driver_s *drv, FAR const void *note,
+                     size_t notelen);
+  CODE void (*start)(FAR struct note_driver_s *drv, FAR void *tcb);
+  CODE void (*stop)(FAR struct note_driver_s *drv, FAR void *tcb);
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SWITCH
+  CODE void (*suspend)(FAR struct note_driver_s *drv, FAR void *tcb);
+  CODE void (*resume)(FAR struct note_driver_s *drv, FAR void *tcb);
+#ifdef CONFIG_SMP
+  CODE void (*cpu_start)(FAR struct note_driver_s *drv, FAR void *tcb,
+                         int cpu);
+  CODE void (*cpu_started)(FAR struct note_driver_s *drv, FAR void *tcb);
+  CODE void (*cpu_pause)(FAR struct note_driver_s *drv, FAR void *tcb,
+                         int cpu);
+  CODE void (*cpu_paused)(FAR struct note_driver_s *drv, FAR void *tcb);
+  CODE void (*cpu_resume)(FAR struct note_driver_s *drv, FAR void *tcb,
+                          int cpu);
+  CODE void (*cpu_resumed)(FAR struct note_driver_s *drv, FAR void *tcb);
+#endif
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_PREEMPTION
+  CODE void (*premption)(FAR struct note_driver_s *drv, FAR void *tcb,
+                         bool locked);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_CSECTION
+  CODE void (*csection)(FAR struct note_driver_s *drv, FAR void *tcb,
+                        bool enter);
+#endif
+#ifdef CONFIG_SCHED_INSTRUMENTATION_SPINLOCKS
+  CODE void (*spinlock)(FAR struct note_driver_s *drv, FAR void *tcb,

Review Comment:
   should we keep the same number of callback like sched_spinlock_xxx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to